search

rapid7 / metasploit-framework

Metasploit Framework
https://www.metasploit.com/
Other
32.92k stars 13.72k forks source link

Add missing '-S' to cmd_notes #19129

Closed nrathaus closed 3 weeks ago

nrathaus commented 3 weeks ago

This is a proposed fix for: https://github.com/rapid7/metasploit-framework/issues/19128

Where '-S' isn't listed in cmd_notes making this code:

notes -S 'nmap.nse.(http|rtsp)'

Doesn't work

Fix includes:

  1. Adding of the missing '-S'
  2. Sort the options alphabetically
adfoster-r7 commented 3 weeks ago

Looks like some failing tests will need to be updated :+1:

smcintyre-r7 commented 3 weeks ago

Release Notes

This fixes a bug where the notes command included an example which contained a flag that was not supported.