search

rapid7 / metasploit-framework

Metasploit Framework
https://www.metasploit.com/
Other
33.23k stars 13.79k forks source link

Dependency inversion in payload_generator library #9923

Open busterb opened 6 years ago

busterb commented 6 years ago

Following up from #9851, it seems that requiring msf/core/payload_generator should not be required in the middle of lib/msf/util/exe in order to get the required constants, but @jmartin-r7 's comment indicates there is a dependency inversion that is causing it. This ticket is for addressing the core issue.

See https://github.com/rapid7/metasploit-framework/pull/9851#issuecomment-380575111

github-actions[bot] commented 3 years ago

Hi!

This issue has been left open with no activity for a while now.

We get a lot of issues, so we currently close issues after 60 days of inactivity. It’s been at least 30 days since the last update here. If we missed this issue or if you want to keep it open, please reply here. You can also add the label "not stale" to keep this issue open!

As a friendly reminder: the best way to see this issue, or any other, fixed is to open a Pull Request.

adfoster-r7 commented 1 year ago

@jmartin-r7 Looks like this issue has been around for a while, is this something we want to attic ? 👀

jmartin-tech commented 1 year ago

Looking at the class I still see some scoping concerns, the require that hightlighted the issue has been hidden away by zeitwerk.

I believe there is still work we should do here.