rapid7 / metasploit-omnibus

Packaging metasploit-framework with omnibus
248 stars 205 forks source link

Update to "Deprecated APT key management utility" Ubuntu 22.04 #192

Closed Crazyhead90 closed 7 months ago

Crazyhead90 commented 1 year ago

With apt-key being deprecated in Ubuntu 22.04, gpg should be used to add keys to the key rings now.

Updated code accordingly:

adfoster-r7 commented 1 year ago

Thanks for the PR! Do you happen to know if this is backwards compatible with older versions of ubuntu?

If not - I think this would need to be updated to handle choosing the old apt-key add code path for older versions, and the new gpg path for newer versions 🤔

Crazyhead90 commented 1 year ago

Thanks for the PR! Do you happen to know if this is backwards compatible with older versions of ubuntu?

If not - I think this would need to be updated to handle choosing the old apt-key add code path for older versions, and the new gpg path for newer versions 🤔

You're welcome!

According to this digitalocean guide (Introduction, paragraph 3), it should be backward compatible. It does however not tell how many version back.. I currently only have an ubuntu 22.04 image running to test it on.

Crazyhead90 commented 1 year ago

It works all the way back to Ubuntu 18.04 at least.. As this is their oldest "supported" version of Ubuntu.

Haven't tested older versions than Ubuntu 18.04, but following their Debian origin, the following versions should at least work as well: Debian Buster (10) - Ubuntu 18's version. Kali 2020.(4?) - based on Debian Buster (10).

nrathaus commented 7 months ago

Any update on this annoying warning during installation?

adfoster-r7 commented 7 months ago

Thanks!