rapid7 / metasploit-payloads

Unified repository for different Metasploit Framework payloads
Other
1.72k stars 666 forks source link

stdapi_channel_open.java file mode equals parameter is incorrect #492

Open XhstormR opened 3 years ago

XhstormR commented 3 years ago

https://github.com/rapid7/metasploit-payloads/blob/master/java/meterpreter/stdapi/src/main/java/com/metasploit/meterpreter/stdapi/stdapi_channel_open.java#L54

"r" should be changed to "w":

        } else if (mode.equals("w") || mode.equals("wb") || mode.equals("wbb")) {
timwr commented 3 years ago

Well spotted @XhstormR Thankfully I think r is not used on the msf side (it's always rb) which explains why this isn't currently causing issues.

Do you mind sending the fix as a pull request please?