search

rapid7 / meterpreter

THIS REPO IS OBSOLETE. USE https://github.com/rapid7/metasploit-payloads INSTEAD
Other
326 stars 143 forks source link

make real_dprintf available even if DEBUGTRACE is not set #129

Closed bcook-r7 closed 9 years ago

bcook-r7 commented 9 years ago

By making this a static _inline, it is not necessary to guard it, since an inline is only instantiated if it is used. This also allows adding one-off debug message for use during debugging sessions, without turning on DEBUGTRACE all over the place.

Convert a few of the extensions to also do this as well, making them perhaps slightly smaller.

I am curious why Windows builds define debug this way, vs posix that just includes it in common.c. Could I just do that instead, assuming there's no historical reason.

Finally, correct the docs in the posix version of real_dprintf.

This doesn't have any effect on the default build output.

metasploit-public-bot commented 9 years ago

Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/149/ Test PASSED.

OJ commented 9 years ago

Seems reasonable to me!

OJ commented 9 years ago

Both linux and windows building cleanly. Looking good.

OJ commented 9 years ago

All looked fine to me, so merged.

OJ commented 9 years ago

Also, first PR merged with new PGP key :dancer:

bcook-r7 commented 9 years ago

Thanks and congratulations!