rapid7 / meterpreter

THIS REPO IS OBSOLETE. USE https://github.com/rapid7/metasploit-payloads INSTEAD
Other
326 stars 144 forks source link

Transport refactor #144

Closed OJ closed 9 years ago

OJ commented 9 years ago

This PR contains a stack of changes that are based around refactoring transport to allow for transport hot-swapping. The goal is to allow the user to change transports on the fly. In order to support this, a number of changes had to happen:

During the course of making these changes, other things were done including:

There is still some work to be done here with regards to making the transport command support setting of proxy and cert hash verification when setting transport to http(s).

The transport command requires a PR on the MSF side of the fence: https://github.com/rapid7/metasploit-framework/pull/5046

There is still work to do, but this at least gets things moving so that people can review things.

Sample runs

I'll add details of the runs to the MSF side so you can see how it works. There'll be overlap in testing with that module and this one.

metasploit-public-bot commented 9 years ago

Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/168/ Test PASSED.

metasploit-public-bot commented 9 years ago

Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/169/ Test PASSED.

metasploit-public-bot commented 9 years ago

Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/170/ Test PASSED.

jlee-r7 commented 9 years ago

Should the tcp transport functions be moved into a new file? Seems odd that it is in the same place as the generic stuff for creating transports, etc, while wininet and winhttp are separate.

OJ commented 9 years ago

Yes, they probably should. Also, the wininet stuff should now be deleted given that we don't (and won't) use it any more.

metasploit-public-bot commented 9 years ago

Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/171/ Test PASSED.

OJ commented 9 years ago

Had some conflicts with master once the WinHTTP proxy fixes made it in. Merged the changes and did some more testing.

metasploit-public-bot commented 9 years ago

Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/172/ Test PASSED.

metasploit-public-bot commented 9 years ago

Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/173/ Test PASSED.

bcook-r7 commented 9 years ago

Testing now to unblock #5046

bcook-r7 commented 9 years ago

posix seems to have broken with the last 3 commits. server_setup exits without a word. at 5f263db things worked fine.

OJ commented 9 years ago

Thanks Brent. Looking at it now!

bcook-r7 commented 9 years ago

no problem - will take a look again later this evening

metasploit-public-bot commented 9 years ago

Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/174/ Test PASSED.

bcook-r7 commented 9 years ago

death to wchar - looks good otherwise!

bcook-r7 commented 9 years ago

I wasn't able to get transport/x64 stageless to work yet, but I'll merge this so far so we have some bins and can work from that.

bcook-r7 commented 9 years ago

Cool beans, I'll have a PR for #5046 shorly. I'm still waiting on GES to add jenkins jobs for the new merged repo, so I'll be giving you manual Linux bins directly again.

bcook-r7 commented 9 years ago

Jenkins issues - will have bins in the morning.