search

rapid7 / meterpreter

THIS REPO IS OBSOLETE. USE https://github.com/rapid7/metasploit-payloads INSTEAD
Other
326 stars 144 forks source link

Remove second instance of the SSL check string #147

Closed OJ closed 9 years ago

OJ commented 9 years ago

The mechanism used for validation of the SSL cert string was the same as for many of the other global replacement options. However, the string value that was used for checking was also the same. The result was that the patch mechanism wasn't patching the right instance of the string.

DERP!

Why this hit stageless only I'm really not sure.

Verification

Thanks to @bcook-r7 for his thorough testing.

Note: This chunk of code is being heavily refactored in another branch, and the checking mechanism will be implemented correctly there as well.

metasploit-public-bot commented 9 years ago

Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/182/ Test PASSED.

bcook-r7 commented 9 years ago

The luck of the linker! Checking it out now.

bcook-r7 commented 9 years ago

Thanks, looks good. Generating new bins now.

OJ commented 9 years ago

Awesome mate, thanks for that.