Closed OJ closed 9 years ago
Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/187/ Test PASSED.
That was quick! Thanks Brent.
I tested them merged together in the first place. Better write some JCL, because I'm in batch mode.
Up until now, all of the transport-specific packet transmit and receive functions has been part of
core.c
, which was included in thecommon.lib
library. This didn't make any sense. The code never belonged there and the common code had nasty#ifdef/#else/endif
blocks all over the shop.This PR moves the transmit and receive code over into
metsrv
where it belongs. The transport-specific mechanisms are now sitting alongside all the other transport-specific things, which removes the need for thepacket_receive
function pointer as well.This is more of a code tidy than a feature enhancement, but I think it's important.
Sample Run and Verification
Everything should run like it does right now, the code should just make more sense.
reverse_http
still functions in Winx64 and Winx86.reverse_https
still functions in Winx64 and Winx86.reverse_tcp
still functions in Winx64, Winx86 and Linux.bind_tcp
still functions in Winx64, Winx86 and Linux.Note: This PR relies on the connection resiliency work done in #151, so that needs to be landed first. Ideally this will be landed around the same time and can be incorporated into the next set of meterpreter binaries.