rapid7 / meterpreter

THIS REPO IS OBSOLETE. USE https://github.com/rapid7/metasploit-payloads INSTEAD
Other
326 stars 144 forks source link

Remove console and file output from kiwi #155

Closed OJ closed 9 years ago

OJ commented 9 years ago

This PR removes both log file and console output from kiwi. This is done so that those people who are unfortunate enough to migrate to a console app before running kiwi don't end up rendering all of the console output to a window that the user can see! Yes, this actually happened.

Verification

metasploit-public-bot commented 9 years ago

Test PASSED. Refer to this link for build results (access rights to CI server needed): https://ci.metasploit.com//job/GPR-MeterpreterWin/188/ Test PASSED.

bcook-r7 commented 9 years ago

LGTM!

OJ commented 9 years ago

Thanks mate!

gentilkiwi commented 9 years ago

344a7f66143012202280153713_700wa_0

OJ commented 9 years ago

I have many more updates coming for this... NEED MOAR TIME!

Meatballs1 commented 9 years ago

Is this in master now? I tried kiwi on Windows 8.1 and Windows 10 and they both crashed meterpreter. I assume this is the only recent change that would affect it?

OJ commented 9 years ago

Yes I think they are. I'll double check.

Meatballs1 commented 9 years ago

I wonder if its a mismatch from some patch level. Latest mimikatz binary isn't having an issue.

OJ commented 9 years ago

Might be. When does the crash happen?

Meatballs1 commented 9 years ago

load kiwi creds_all/lsa_dump/etc CRASH!

OJ commented 9 years ago

That is odd. Shouldn't ever see that, regardless of versions.

bcook-r7 commented 9 years ago

Just tried it again on Win 8.1 32 & 64-bit but did not see a problem. Any other specifics to share?

OJ commented 9 years ago

See, or don't see?

bcook-r7 commented 9 years ago

I had a typo. It does not crash as far as I can tell just running creds_all. I need a more complete list of steps in order to reproduce.