search

rapid7 / nexpose-client-python

DEPRECATED : Rapid7 Nexpose API client library written in Python
https://www.rapid7.com/
BSD 3-Clause "New" or "Revised" License
25 stars 20 forks source link

Improvements for AssetDetails, Tags & Unique Identifiers + Adhoc Reports #43

Closed fruechel closed 6 years ago

fruechel commented 6 years ago

Tags & Unique Identifiers are now supported similar to the Ruby client. Adhoc reports can be generated in more than XML.

Description

See commit messages for more details. They outline each change.

Motivation and Context

These changes are needed for our use case of Nexpose. All changes are backwards-compatible improvements which is why they are in a PR.

How Has This Been Tested?

No additional tests have been added but all changes have been verified and are being used by our code. All old tests still work (which is expected given that all changes are backwards-compatible). Changes have only been tested in Python 3. The only potential problem is the new CSV parsing function which has been explicitly tested & verified for Python 2 as well.

Types of changes

Checklist:

There's no docs for any of the areas I touched so I didn't add any either. Same goes for tests.

gschneider-r7 commented 6 years ago

I fixed (well, more like bandaid) the flake8 issues on master so if you rebase travis-ci should pass on this PR.

gschneider-r7 commented 6 years ago

Also as far as reporting goes, let me know if you have any feedback on #37

fruechel commented 6 years ago

I merged in master, seems this worked. As for #37 it looks like we should combine the changes since they touch similar parts. I'll have a closer look. If you want I can remove the report commit from this PR and we work on #37 to incorporate both changes. Does that work for you?

gschneider-r7 commented 6 years ago

I don't mind having your report changes here as well since this PR could probably get into a released version sooner than #37. Feel free to PR any suggested changes to the report_configs branch, then I can review and merge to #37.

fruechel commented 6 years ago

Does this mean we can merge these changes into master or do you need anything from me before making that merge?

gschneider-r7 commented 6 years ago

These changes are published in v0.1.7, available on pypi now.

fruechel commented 6 years ago

That was really fast, thank you!