Open fruechel opened 6 years ago
I did just realise that the update to 6.4.66 actually pushed out some changes regarding the API. I'm looking at the /integration-options
endpoint now, trying to implement it in a user-friendly way. That is, like the UI does, you shouldn't have to manually handle all of these details.
This mirrors the changes in https://github.com/rapid7/nexpose-client/pull/309 but limited to discovery connections.
Description
Implement support for ESO API for discovery connections. Based on @hwilson-r7's changes in https://github.com/rapid7/nexpose-client/pull/309
EsoConfiguration
class to handle all types of configurationAWSConfiguration
class to address that particular use case.Looking for feedback on whether this is the way you'd like this implemented or if changes are needed.
Motivation and Context
This API is new and there is no support for it yet. We're looking at using it.
How Has This Been Tested?
I created a test script that runs through most functionality. The following things are known issues:
The following things have been tested and work:
A recent update does also seem to cause 401s unless
X-Requested-With: XMLHttpRequest
HTTP headers are sent. This seems like a weird bug introduced in 6.4.66 so I didn't include it in the PR, assuming it'll go away once fixed there.No unit tests have been written.
This is the function used to test things:
Types of changes
Checklist: