Fix handling of AdhocReport response (#47)

rapid7 / nexpose-client-python

DEPRECATED : Rapid7 Nexpose API client library written in Python

https://www.rapid7.com/

BSD 3-Clause "New" or "Revised" License

25 stars 20 forks source link

Fix handling of AdhocReport response (#47) #48

Closed fruechel closed 6 years ago

fruechel commented 6 years ago

Not using XML directly any more. This can cause large reports to fail parsing. Removed comment that indicated we shouldn't be doing this ;-)

Types of changes

Bug fix (non-breaking change which fixes an issue)

fruechel commented 6 years ago

@gschneider-r7 this is in relation to #47 and fixes the error we're seeing. The bug was present already but only exposed through my PR #43. Now we're not using as_xml directly but rather only on the part that's actually an XML response. the other part is properly treated as CSV straight away.

Tested the CSV component but not how an XML report is handled. However, the way the code changed there should not be any difference.

gschneider-r7 commented 6 years ago

I don't have time to test this myself currently, so if you need this merged and published I'll have to take your word for it that it works. 😉 Just let me know if you need me to push it out.

The changes otherwise look fine to me.

fruechel commented 6 years ago

Yup, we're currently pinned to the dev commit in my repo and it keeps happily importing. Haven't seen any issues since we pushed out this fix. Thanks.