rapid7 / recog

Pattern recognition for hosts, services, and content
Other
671 stars 199 forks source link

CPE: use safe_load, update CPEs #296

Closed tsellers-r7 closed 4 years ago

tsellers-r7 commented 4 years ago

Description

This PR changes update_cpes.py so that it uses yaml.safe_load() instead of yaml.load(). This should reduce the risk when loading YAML. I've also run it against our fingerprint databases using the latest data from NIST.

I've also added a .snyk file in order to suppress the Synk warning on PyYAML. We don't currently use a vulnerable code path, Snyk doesn't check to see if you are using the vulnerable code path, and there is no full library level fix for this other than to use safe_load() (which this PR does) or the SafeLoader loader.

https://app.snyk.io/vuln/SNYK-PYTHON-PYYAML-590151

Motivation and Context

Risk reduction

How Has This Been Tested?

rspec, Github PR hooks

Types of changes

Checklist: