search

rapid7 / recog

Pattern recognition for hosts, services, and content
Other
662 stars 195 forks source link

Proposal: migrate host.id to hw.serial_number for storing hardware serial numbers #364

Closed tsellers-r7 closed 3 years ago

tsellers-r7 commented 3 years ago

Proposal: Store hardware serial numbers in hw.serial_number instead of host.id.

In some cases recog is using host.id to store hardware serial numbers when they are captured from banners. I would like to change this, where appropriate, to a new field hw.serial_number. This would make it more clear as to what is being captured and move the data to a more appropriate context (hw).

https://github.com/rapid7/recog/search?q=host.id

In the cases where we have existing vendor specific serial numbers I would duplicate these values in hw.serial_number unless stakeholders indicate that these are not being used at all.

https://github.com/rapid7/recog/search?q=serial_number

Any feedback on this change would be greatly appreciated!

CC: @hdm @dabdine

hdm commented 3 years ago

+1 here, thanks!

rkirk-r7 commented 3 years ago

+1 too

tsellers-r7 commented 3 years ago

I have opened PR #366 to implement this change.

tsellers-r7 commented 3 years ago

The change has been landed. Thanks for the feedback here and elsewhere folks.