rapid7 / recog

Pattern recognition for hosts, services, and content
Other
662 stars 195 forks source link

Field migration: host.id -> hw.serial_number #366

Closed tsellers-r7 closed 3 years ago

tsellers-r7 commented 3 years ago

Description

This PR implements the change discussed in Issue #364.

The changes:

Motivation and Context

The intent is to add clarity to the data that is captured. The field host.id was unclear and was being used to capture hostnames as well as serial numbers.

How Has This Been Tested?

rspec, fingerprint example captures.

Types of changes

Checklist:

tsellers-r7 commented 3 years ago

cc @hdm @dabdine

hdm commented 2 years ago

I agree with changing to hw.serial_number as a consistent field, but there may be some adjustment needed on the Rumble side (if not Nexpose too).