rapid7 / recog

Pattern recognition for hosts, services, and content
Other
662 stars 195 forks source link

Add explicit certainty for Assert Nothings #369

Closed tsellers-r7 closed 3 years ago

tsellers-r7 commented 3 years ago

Description

This PR explicitly sets the certainty levels for certain Assert Nothing style fingerprint matches. The intent is to convey that all other matches to a banner or endpoint should be given priority over these specific matches. For example, a http_server match may be too generic to have value but the x509 issuer may also match and we want that second one to win always.

How Has This Been Tested?

rspec

Checklist:

tsellers-r7 commented 3 years ago

CC @hdm @dabdine

hdm commented 3 years ago

Looks good to me! (deleted incorrect comment about 0 vs 0.0)