rapid7 / recog

Pattern recognition for hosts, services, and content
Other
662 stars 195 forks source link

Add recog_standardize pre-commit hook #371

Closed mkienow-r7 closed 3 years ago

mkienow-r7 commented 3 years ago

Description

Introduces a git pre-commit hook to run bin/recog_standardize on any staged XML fingerprint files. This will help contributors verify that each fingerprint asserts known identifiers. These changes required enhancement of bin/recog_standardize to return an exit code in order to support scripting.

Motivation and Context

Explanation of why these changes are being proposed, including any links to other relevant issues or pull requests. Help contributors catch concerns before changes are committed and pull requests are opened. Save everyone a little time and help get contributions merged quicker!

How Has This Been Tested?

New field names and new field values were added to xml fingerprints, then attempted to commit the changes to trigger the pre-commit hook script.

Types of changes

Checklist: