rapid7 / recog

Pattern recognition for hosts, services, and content
Other
662 stars 195 forks source link

Add multi-language recog verify to GitHub verify workflow #375

Closed mkienow-r7 closed 2 years ago

mkienow-r7 commented 2 years ago

Description

Enhances the GitHub verify workflow to run Ruby, Java and Go implementations of the recog fingerprint verification tool on any modified XML fingerprint files. This will help contributors and pull request reviewers verify at a minimum that each fingerprint example is matched and all parameters that are defined by capture groups have the expected value. Note, warnings are currently disabled in the tools that provide warnings (Ruby and Java), and will be enabled once all of the warnings in the existing fingerprints are corrected.

Motivation and Context

Help contributors and pull request reviewers catch concerns.

How Has This Been Tested?

  1. Opened PR against my recog fork
  2. Patched xml/ fingerprints to introduce issues
  3. Committed and pushed changes
  4. Confirmed Ruby Verify, Java Verify, and Go Verify workflow jobs all failed
  5. Committed and pushed changes to undo the changes applied by the patch
  6. Confirmed all Verify workflows were not run since xml files under xml/ were no longer different

Types of changes

Checklist: