rapid7 / recog

Pattern recognition for hosts, services, and content
Other
662 stars 195 forks source link

Add missing parameters on x509.subject examples #380

Closed mkienow-r7 closed 2 years ago

mkienow-r7 commented 2 years ago

Description

Adds missing parameters on x509.subject examples in order to address recog_verify warnings.

Before

./bin/recog_verify xml/x509_subjects.xml
xml/x509_subjects.xml: WARN: 'HP iLO' is missing an example that checks for parameter 'host.name' which is derived from a capture group
xml/x509_subjects.xml: WARN: 'HP iLO (Onboard Administrator)' is missing an example that checks for parameter 'host.mac' which is derived from a capture group
xml/x509_subjects.xml: WARN: 'HP iLO - Enterprise Mgmt variant' is missing an example that checks for parameter 'host.name' which is derived from a capture group
xml/x509_subjects.xml: WARN: 'VMware ESX' is missing an example that checks for parameter 'host.name' which is derived from a capture group
xml/x509_subjects.xml: WARN: 'Canon iR-ADV Printer with product info' is missing an example that checks for parameter 'hw.product' which is derived from a capture group
xml/x509_subjects.xml: WARN: 'NEC DT Series IP Phone' is missing an example that checks for parameter 'hw.product' which is derived from a capture group
xml/x509_subjects.xml: WARN: 'Proxmox open-source virtualization platform' is missing an example that checks for parameter 'host.name' which is derived from a capture group
xml/x509_subjects.xml: SUMMARY: Test completed with 182 successful, 7 warnings, and 0 failures

After

./bin/recog_verify xml/x509_subjects.xml
xml/x509_subjects.xml: SUMMARY: Test completed with 182 successful, 0 warnings, and 0 failures

Motivation and Context

Clean up examples.

How Has This Been Tested?

Types of changes

Checklist: