Simplifies many fingerprint regular expressions by removing unnecessary:
trailing dot matches
leading dot matches
non-capturing group
Motivation and Context
Many thanks to @jvoisin for taking the time to propose these three changes in #332! Unfortunately that PR was left open for months and the merge conflicts were a bit of a mess since subsequent PRs removed unnecessary capture groups.
These changes increase fingerprint regular expression readability and remove unnecessary matching.
How Has This Been Tested?
rake tests
No differences in the recog_verify output from before and after the changes. ./bin/recog_verify xml/*.xml > after.txt; diff before.txt after.txt
Types of changes
N/A
Checklist:
[x] I have updated the documentation accordingly (or changes are not required).
[x] I have added tests to cover my changes (or new tests are not required).
Description
Simplifies many fingerprint regular expressions by removing unnecessary:
Motivation and Context
Many thanks to @jvoisin for taking the time to propose these three changes in #332! Unfortunately that PR was left open for months and the merge conflicts were a bit of a mess since subsequent PRs removed unnecessary capture groups.
These changes increase fingerprint regular expression readability and remove unnecessary matching.
How Has This Been Tested?
rake testsrecog_verifyoutput from before and after the changes../bin/recog_verify xml/*.xml > after.txt; diff before.txt after.txtTypes of changes
N/A
Checklist: