rapid7 / recog

Pattern recognition for hosts, services, and content
Other
671 stars 199 forks source link

Modify telnet patterns to fix recog-java compatibility #385

Closed mkienow-r7 closed 2 years ago

mkienow-r7 commented 3 years ago

Description

Small xml/telnet_banners.xml pattern modifications to fix issues with recog-java compatibility.

Motivation and Context

Resolve recog-java fingerprint issues introduced when adding support for base64 encoded examples in rapid7/recog-java#15.

com.rapid7.recog.verify.RecogVerifier failures

xml/telnet_banners.xml: FAIL: 'HP Printer - Jet Direct' failed to match "HP JetDirect
<snip>
" with '^(?:\r|\n)*HP JetDirect(?:\r|\n)+$'
xml/telnet_banners.xml: FAIL: 'HP Printer - Jet Direct' failed to match "HP JetDirect
<snip>
" with '^(?:\r|\n)*HP JetDirect(?:\r|\n)+$'
xml/telnet_banners.xml: FAIL: 'Windows 2000' failed to match "Microsoft (R) Windows NT (TM) Version 4.00 (Build 1381)
<snip>
login: " with '^Telnet Server Build (5.*)'
xml/telnet_banners.xml: WARN: 'Arescom System' is missing an example that checks for parameter 'hw.model' which is derived from a capture group
xml/telnet_banners.xml: FAIL: 'HP ProCurve Switch' failed to match "
<snip>
Username: " with '^HP ([^\s]+) ProCurve Switch'
xml/telnet_banners.xml: SUMMARY: Test completed with 154 successful, 1 warnings, and 4 failures

How Has This Been Tested?

Types of changes

Checklist: