Enhance recog verify to report an untested parameter as a failure - Githubissues

rapid7 / recog

Pattern recognition for hosts, services, and content

Other

671 stars 199 forks source link

Enhance recog verify to report an untested parameter as a failure #405

Closed mkienow-r7 closed 2 years ago

mkienow-r7 commented 2 years ago

Description

Enhances recog_verify to report an untested parameter as a failure instead of a warning.

Motivation and Context

Ensure all fingerprints have examples that fully verify all capture group parameters.

How Has This Been Tested?

rake tests

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

[x] I have updated the documentation accordingly (or changes are not required).
[x] I have added tests to cover my changes (or new tests are not required).
[x] All new and existing tests passed.

dabdine commented 2 years ago

LGTM.

Should we add an aruba test (in veatures/verify.feature + corresponding 'data' dir file) to validate the output as FAIL?

When I added the change to eliminate some of the warnings, I had to also update verify.feature to remove the WARN lines from the ProFTPd test case that would've otherwise failed. In retrospect, I should've separated them out to a separate test case and file in the data dir.

EDIT: Actually, i think you can do this easily by adding another xml element to the tests_with_failures.xml file and the corresponding case in verify.feature.