Fix examples in architecture.xml, ftp_banners.xml, and ssh_banners.xml

dabdine commented 2 years ago

Description

Fixes fingerprint examples & regular expression issues in ftp_banners.xml, architecture.xml, and ssh_banners.xml. These files no longer yield any warnings whatsoever.

Motivation and Context

Eliminate more warnings & fix bad regular expressions in some fingerprints.

How Has This Been Tested?

bundle exec rake tests

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have updated the documentation accordingly (or changes are not required).
[x] I have added tests to cover my changes (or new tests are not required).
[x] All new and existing tests passed.

dabdine commented 2 years ago

Added one fix for ssh_servers.xml as well, but this file still has warnings to address.

dabdine commented 2 years ago

I went ahead and remediated all remaining SSH examples in ssh_banners.xml. This PR now closes out all issues on the three mentioned files.

mkienow-r7 commented 2 years ago

Thank you for the contribution @dabdine!

rapid7 / recog