Fix greedy service.version capture group for EmWeb variants - Githubissues

rapid7 / recog

Pattern recognition for hosts, services, and content

Other

671 stars 199 forks source link

Fix greedy service.version capture group for EmWeb variants #413

Closed mkienow-r7 closed 2 years ago

mkienow-r7 commented 2 years ago

Description

Fixes a greedy service.version capture group for EmWeb variants.

Motivation and Context

Fixes incorrect matches where the EmWeb variant server header appears in a large string of HTTP server headers.

How Has This Been Tested?

rake tests
echo "Server Server Server Virata-EmWeb/R6_2_1 Server Server Server" | ./bin/recog_match xml/http_servers.xml

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have updated the documentation accordingly (or changes are not required).
[x] I have added tests to cover my changes (or new tests are not required).
[x] All new and existing tests passed.