rapid7 / recog

Pattern recognition for hosts, services, and content
Other
671 stars 199 forks source link

Add RuboCop (linter) workflow #417

Closed mkienow-r7 closed 1 year ago

mkienow-r7 commented 2 years ago

Is your feature request related to a problem? Please describe. Make it easier for contributors and maintainers to ensure code adheres to a proper style and format.

Describe the solution you'd like Run RuboCop on push to main branch and on pull requests.

Describe alternatives you've considered None

Additional context N/A

adfoster-r7 commented 1 year ago

Would we want this issue moved over to the https://github.com/rapid7/recog-ruby repo? Or should rubocop be applied to both repositories

mkienow-r7 commented 1 year ago

@adfoster-r7 Yes, recog-ruby needs this work. This issue was opened before the repository split. I created a new issue on recog-ruby, and I'm going to leave this open since we have a handful of Ruby scripts in this repository.

adfoster-r7 commented 1 year ago

Closed by https://github.com/rapid7/recog/pull/579