Closed mkienow-r7 closed 2 years ago
Fixes regex capture issues pointed out in #400.
Fix regex issues discovered after adding missing example capture group attributes.
Verified "Windows 10 Mobile" os.edition was not incorrectly captured
os.edition
$ echo "Windows 10 Mobile Edition" | ./bin/recog_match xml/operating_system.xml MATCH: {"matched"=>"Windows 10 Mobile", "os.vendor"=>"Microsoft", "os.family"=>"Windows", "os.product"=>"Windows 10 Mobile", "os.edition"=>nil, "os.device"=>"Mobile", "os.cpe23"=>"cpe:/o:microsoft:windows_10_mobile:-", "service.protocol"=>"", "fingerprint_db"=>"operating_system.name", "data"=>"Windows 10 Mobile Edition"} $ echo "Windows 10 Mobile" | ./bin/recog_match xml/operating_system.xml MATCH: {"matched"=>"Windows 10 Mobile", "os.vendor"=>"Microsoft", "os.family"=>"Windows", "os.product"=>"Windows 10 Mobile", "os.edition"=>nil, "os.device"=>"Mobile", "os.cpe23"=>"cpe:/o:microsoft:windows_10_mobile:-", "service.protocol"=>"", "fingerprint_db"=>"operating_system.name", "data"=>"Windows 10 Mobile"}
rake tests
Description
Fixes regex capture issues pointed out in #400.
Motivation and Context
Fix regex issues discovered after adding missing example capture group attributes.
How Has This Been Tested?
Verified "Windows 10 Mobile"
os.edition
was not incorrectly capturedrake tests
Types of changes
Checklist: