rapid7 / recog

Pattern recognition for hosts, services, and content
Other
671 stars 199 forks source link

Repository split - remove recog library #437

Closed mkienow-r7 closed 2 years ago

mkienow-r7 commented 2 years ago

Description

Split the Recog content - XML fingerprint files and utilities - from the Ruby Recog framework library implementation. Note that the rapid7/recog-ruby repository was created as a clone of the rapid7/recog repository at commit fac7d6d6688330b155fd35f80eacc920ec9db75e and both were split after this commit. See the other side of the split in rapid7/recog-ruby#1.

After this PR is merged an organization administrator will rename the repository's default branch from master to main.

Motivation and Context

Separates the Recog content from the Ruby Recog framework library implementation since there are two other language implementations ([rapid7/recog-java](https://github.com/rapid7/recog-java & RumbleDiscovery/recog-go) that also use the Recog content.

How Has This Been Tested?

Types of changes

Checklist:

mkienow-r7 commented 2 years ago

@hdm, @TomSellers, @pbarry25 please review these changes.

TomSellers commented 2 years ago

I definitely want @hdm and @pbarry25 to comment on this but local testing indicates that the content and tooling in bin/ still work as expected outside of Rumble. The biggest change is just doing a bundle install (or rbenv exec bundle install) when getting setup.

hdm commented 2 years ago

no problem here, we can adjust as needed