DHCP fingerprints for Polycom SoundStation IP

rapid7 / recog

Pattern recognition for hosts, services, and content

Other

662 stars 195 forks source link

DHCP fingerprints for Polycom SoundStation IP #496

Closed dmoinescu-r7 closed 1 year ago

dmoinescu-r7 commented 1 year ago

Description

DHCP fingerprints for Polycom SoundStation IP, as observed in DHCP network traffic.

Motivation and Context

How Has This Been Tested?

Ran recog_verify, recog_standardize and update_cpes.py

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

[x] I have updated the documentation accordingly (or changes are not required).
[x] I have added tests to cover my changes (or new tests are not required).
[x] All new and existing tests passed.

mkienow-r7 commented 1 year ago

The tests are failing since the example hw.product values were not updated.

$ bundle exec ./bin/recog_verify xml/dhcp_vendor_class.xml
xml/dhcp_vendor_class.xml:148: FAIL: 'Polycom SoundStation IP Phone' failed to find expected capture group hw.product '6000'. Result was SoundStation IP 6000
xml/dhcp_vendor_class.xml:148: FAIL: 'Polycom SoundStation IP Phone' failed to find expected capture group hw.product '7000'. Result was SoundStation IP 7000
xml/dhcp_vendor_class.xml: SUMMARY: Test completed with 81 successful, 0 warnings, and 2 failures

dmoinescu-r7 commented 1 year ago

The tests are failing since the example hw.product values were not updated.

Thanks, sorry about that. I'd seen the test failures, was wondering why (I must've forgotten to re-run recog_verify after the latest updates). Fixed now