The xml/imap_banners.xml fingerprints were created assuming the * OK portion of the banner was removed, but some of the fingerprint patterns did not account for the possibility of the [CAPABILITY ...] string in the banner. This PR adds the missing IMAP CAPABILITY string to the pattern and provides examples. In addition, the "CMU Cyrus IMAP" fingerprint was enhanced to spport banners without v prepended to the version. The IMAP CAPABILITY string max match length of 645 was calculated using the longest CAPABILITY string found in the 2022-10-13-1665619548-imaps_993_stage2 Project Sonar study (658 characters) and subtracting the fixed portion of the regex [CAPABILITY ] (13 characters).
Description
The
xml/imap_banners.xml
fingerprints were created assuming the* OK
portion of the banner was removed, but some of the fingerprint patterns did not account for the possibility of the[CAPABILITY ...]
string in the banner. This PR adds the missing IMAP CAPABILITY string to the pattern and provides examples. In addition, the "CMU Cyrus IMAP" fingerprint was enhanced to spport banners withoutv
prepended to the version. The IMAP CAPABILITY string max match length of 645 was calculated using the longest CAPABILITY string found in the2022-10-13-1665619548-imaps_993_stage2
Project Sonar study (658 characters) and subtracting the fixed portion of the regex[CAPABILITY ]
(13 characters).Motivation and Context
Improved coverage
How Has This Been Tested?
bundle exec ./bin/recog_verify xml/imap_banners.xml
rake tests
Types of changes
Checklist: