rapid7 / recog

Pattern recognition for hosts, services, and content
Other
662 stars 195 forks source link

Sortlines on all identifiers/*.txt #517

Closed todb-r7 closed 1 year ago

todb-r7 commented 1 year ago

Description

Presumably, the intent is to keep these alphabetized so new people can pop in and add new entries in a sane way. Looks like the alphabetization has gotten a little loose.

If there's a performance reason to keep these strategically semi-sorted, then please reject this change.

Motivation and Context

Make it easier for people to sense where to insert their new entries.

The only change here is alphabetization. I didn't do anything like add/remove newlines, spellcheck, or sneak in new entries.

How Has This Been Tested?

In absolutely no way has this been tested beyond my human eyeballs.

Types of changes

Checklist:

mkienow-r7 commented 1 year ago

The identifiers/* files should not be manually edited. These are managed by ./bin/recog_standardize.

todb-r7 commented 1 year ago

This is a bad idea, forget it. See #438, there's a sorting in place already.