Rename SSL-VPN *.device parameter values to be more generic - Githubissues

rapid7 / recog

Pattern recognition for hosts, services, and content

Other

662 stars 195 forks source link

Rename SSL-VPN *.device parameter values to be more generic #559

Closed mkienow-r7 closed 1 year ago

mkienow-r7 commented 1 year ago

Description

Renames "SSL-VPN" *.device parameter values to the more generic value "VPN".

Motivation and Context

Provide concise device classification

How Has This Been Tested?

rake tests
bundle exec ./bin/recog_verify xml/dhcp_vendor_class.xml xml/html_title.xml xml/http_cookies.xml

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have updated the documentation accordingly (or changes are not required).
[x] I have added tests to cover my changes (or new tests are not required).
[x] All new and existing tests passed.

mkienow-r7 commented 1 year ago

@adfoster-r7 I ran the idea by @TomSellers of runZero before opening the PR and he agreed with them.