Correct param order in Sonarr, Radarr, Prowlarr fingerprints - Githubissues

rapid7 / recog

Pattern recognition for hosts, services, and content

Other

662 stars 195 forks source link

Correct param order in Sonarr, Radarr, Prowlarr fingerprints #575

Closed mkienow-r7 closed 1 year ago

mkienow-r7 commented 1 year ago

Description

Corrects the param order in the Sonarr, Radarr and Prowlarr fingerprints added in #571.

Motivation and Context

Maintain consistent param order

How Has This Been Tested?

bundle exec ./bin/recog_verify xml/favicons.xml xml/html_title.xml xml/http_wwwauth.xml
rake tests

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist:

[x] I have updated the documentation accordingly (or changes are not required).
[x] I have added tests to cover my changes (or new tests are not required).
[x] All new and existing tests passed.

mkienow-r7 commented 1 year ago

For visibility, does this order impact anything? Or is it just for consistency

It is simply for consistency. It's in my backlog to add parameter order normalization to the cleanup script. That should make it easier for everyone.