Favicon signature updates - Githubissues

rapid7 / recog

Pattern recognition for hosts, services, and content

Other

662 stars 195 forks source link

Favicon signature updates #619

Closed adungo-r7 closed 2 months ago

adungo-r7 commented 2 months ago

Description

This PR includes updates to improve existing favicon fingerprints and also adds a bunch more new signatures worked on by @cbeek-r7

Update Summary: 290 new fingerprints 17 existing fingerprints updated

Motivation and Context

Improving existing favicon fingerprints and adding new signatures.

How Has This Been Tested?

bundle exec rubocop --parallel --format simple
bundle exec bin/recog_standardize xml/*.xml
bundle exec bin/recog_verify --schema-location xml/fingerprints.xsd --no-warnings xml/*.xml
bundle exec rake tests (All tests pass)

Types of changes

New feature (non-breaking change which adds functionality)

Checklist:

[x] I have updated the documentation accordingly (or changes are not required).
[x] I have added tests to cover my changes (or new tests are not required).
[x] All new and existing tests passed.

adungo-r7 commented 2 months ago

@adfoster-r7 I was cross-referencing with other favicon databases such as OWASP's one, and DocuWiki and Nagios seem to be versioned with the same MD5 hashes, but I also don't see any harm with not versioning it? Since like you said they haven't changed in years.. What do you think?

https://owasp.org/www-community/favicons_database#:~:text=dokuwiki%20(0.0.20080505),MD5%3A%203ef81fad2a3deaeb19f02c9cf67ed8eb

https://owasp.org/www-community/favicons_database#:~:text=nagios%20(3.0.2),MD5%3A%201c4201c7da53d6c7e48251d3a9680449