rapid7 / recog

Pattern recognition for hosts, services, and content
Other
662 stars 195 forks source link

update openldap root dse fp pattern #621

Closed gustavoluvizotto closed 2 months ago

gustavoluvizotto commented 2 months ago

Description

Updated the fingerprint matching pattern to identify more OpenLDAP instances.

Motivation and Context

When queried by the RootDSE, OpenLDAP servers could be identified under the objectClass attribute name or structuralObjectClass attribute name. Hence, it is necessary to adapt the current matching pattern to identify such servers.

Here are a few examples: With objectClass: https://search.censys.io/hosts/61.222.164.42/data/table#389-TCP-LDAP With structuralObjectClass: https://search.censys.io/hosts/213.55.162.229/data/table#636-TCP-LDAP

How Has This Been Tested?

  1. rake tests

    Output:

    
    ...

Finished in 1 minute 15.75 seconds (files took 17.88 seconds to load) 186303 examples, 0 failures

Randomized with seed 53283

Coverage report generated for RSpec to /recog/coverage. 82 / 82 LOC (100.0%) covered. ...


2.
```shell
bin/recog_verify xml/ldap_searchresult.xml

Output:

xml/ldap_searchresult.xml: SUMMARY: Test completed with 69 successful, 0 warnings, and 0 failures

Types of changes

Checklist:

gustavoluvizotto commented 2 months ago

@dtwaddle2-r7 @adfoster-r7 @jira-r7 Can someone review my PR?

adfoster-r7 commented 2 months ago

Tests are passing now; thanks!