Make the synchronization functions public - Githubissues

rapid7 / rex-core

Created by David Maloney via the GitHub Connector

Other

4 stars 23 forks source link

Make the synchronization functions public #16

Closed zeroSteiner closed 3 years ago

zeroSteiner commented 3 years ago

This makes the synchronize_access and synchronize_update methods provided by the stream module public which allows them to be used elsewhere.

This is helpful to protect certain operations that may involve more than one read / write operation such as:

Initializing an SSL socket which has it's own negotiation sequence involving multiple reads and writes
Reading a response of a variable size (such as when using BinData::Record#read)

I'll have a PR requiring these changes up shortly that'll show them in action.

gwillcox-r7 commented 3 years ago

LGTM, will get this merged in now.