search

rapid7 / rex-core

Created by David Maloney via the GitHub Connector
Other
4 stars 23 forks source link

Update compat.rb #36

Closed Xhoenix closed 1 year ago

Xhoenix commented 1 year ago

Added xdg-open, as using metasploit info -d sometimes doesn't opens the html page in a browser.

bcoles commented 1 year ago

Fixes #9

Xhoenix commented 1 year ago

Yes. I'm using it in the Metasploit snap package for 8 months now. I should've open this PR earlier.

Xhoenix commented 1 year ago

This issue is four years old and yet it's not fixed. Why?

bcoles commented 1 year ago

This issue is four years old and yet it's not fixed. Why?

Because you opened your PR yesterday.

Xhoenix commented 1 year ago

Lol. I meant the issue #9 clearly mentions the solution and you guys are clearly way better than me at ruby. 😅

Anyways, you can test the snap package of metasploit and you'll see this fix works fine.

smcintyre-r7 commented 1 year ago

I also noticed that you opened the PR from the master branch. In the future, we'd prefer to see PRs from a topic branch. We actually enforce this on PRs to metasploit-framework.

Thanks for your pull request! We require for all contributed code to come from a from a unique branch in your repository before it can be merged.

For context you'll see this message including reasoning behind this preference.

Please create a new branch in your fork of framework and resubmit this from that branch.

If you are using Git on the command line that may look like:

# Checkout the master branch
git checkout master

# Create a new branch for your feature
git checkout -b <BRANCH_NAME>

# Add your new files
git add modules/my-cool-new-module

# Commit your changes with a relevant message
git commit

# Push your changes to GitHub
git push origin <BRANCH_NAME>

# Now browse to the following URL and create your pull request!
# - https://github.com/rapid7/metasploit-framework/pulls
This helps protect the process, ensure users are aware of commits on the branch being considered for merge, allows for a location for more commits to be offered without mingling with other contributor changes and allows contributors to make progress while a PR is still being reviewed.

Please do resubmit from a unique branch, we greatly value your contribution! :tada:
Xhoenix commented 1 year ago

Open another PR #37 from a different branch. Take a look at that.