rapid7 / rex-core

Created by David Maloney via the GitHub Connector
Other
4 stars 23 forks source link

Updating open_webrtc_browser() in Compat.rb #9

Open hkerma opened 5 years ago

hkerma commented 5 years ago

Hi, I opened an issue for msf because I was having troubles with opening documentation. Finally, I found out that open_browser() function were using 'xdg-open' and 'sensible-browser' first (which I think is a good thing) but open_webrtc_browser() uses 'google-chrome' first.

I've found out two solutions :

Could someone tell me what solution in your opinion, is the best ? I'll then make the modifications and make a pull request.

hkerma commented 5 years ago

Hi ! As I get no answer, I'll make a PR soon with open_webrtc_browser() calling 'xdg-open' and 'sensible-browser' first !

busterb commented 5 years ago

Sounds great, thanks @hkerma