search

rapid7 / ruby_smb

A native Ruby implementation of the SMB Protocol Family
Other
79 stars 82 forks source link

Bump the minor version #185

Closed cdelafuente-r7 closed 2 years ago

cdelafuente-r7 commented 2 years ago

Since the redesign of the NDR structures changed some exposed API's, bumping the patch version was not enough.

smcintyre-r7 commented 2 years ago

@jmartin-r7 Are we sure this should be the minor version and not the major version per item 8 in the Semantic Versioning spec?

jmartin-tech commented 2 years ago

@smcintyre-r7, you are correct the exposed object are public and not backwards compatible so this would warrant a major bump.