rapid7 / ruby_smb

A native Ruby implementation of the SMB Protocol Family
Other
79 stars 82 forks source link

Improve error reporting #192

Open cdelafuente-r7 opened 2 years ago

cdelafuente-r7 commented 2 years ago

RubySMB exception usually consists of a simple string that includes the error code, error name and a custom message. It requires the caller to perform string comparison in the raw message string to get the exact error code or name. See this PR's comment. I believe this can be improved by using more elaborate exception classes containing helpers to extract specific information.