Open gwillcox-r7 opened 2 years ago
The ShortNameLength field in FileIdBothDirectoryInformationdefinition at https://github.com/rapid7/ruby_smb/blob/master/lib/ruby_smb/fscc/file_information/file_id_both_directory_information.rb#L22 is incorrect. It is defined as a unsigned 8 bit integer in our code but https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/1e144bff-c056-45aa-bd29-c13d214ee2ba?redirectedfrom=MSDN now defines it as a signed 8 bit integer. We should update this accordingly.
ShortNameLength
FileIdBothDirectoryInformation
The
ShortNameLengthfield inFileIdBothDirectoryInformationdefinition at https://github.com/rapid7/ruby_smb/blob/master/lib/ruby_smb/fscc/file_information/file_id_both_directory_information.rb#L22 is incorrect. It is defined as a unsigned 8 bit integer in our code but https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/1e144bff-c056-45aa-bd29-c13d214ee2ba?redirectedfrom=MSDN now defines it as a signed 8 bit integer. We should update this accordingly.