search

rapid7 / ruby_smb

A native Ruby implementation of the SMB Protocol Family
Other
80 stars 80 forks source link

FileNameInformation Link No Longer Contains Structure Info #221

Open gwillcox-r7 opened 2 years ago

gwillcox-r7 commented 2 years ago

https://github.com/rapid7/ruby_smb/blob/master/lib/ruby_smb/fscc/file_information/file_name_information.rb#L5 contains a link to https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/cb30e415-54c5-4483-a346-822ea90e1e89 however it seems like MS removed the definition of the fields here so the only way to review this information now is to download the specs file from https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/efbfe127-73ad-4140-9967-ec6500e66d5e.

It may be worthwhile considering if we want to update the link accordingly.

gwillcox-r7 commented 2 years ago

Actually this should link to https://docs.microsoft.com/en-us/openspecs/windows_protocols/ms-fscc/20406fb1-605f-4629-ba9a-c67ee25f23d2 I stand corrected, which defines this structure. It appears the link was to the wrong definition and someone searched for FILENAMEINFORMATION vs FILE_NAME_INFORMATION and therefore got the wrong definition.