search

rapid7 / ruby_smb

A native Ruby implementation of the SMB Protocol Family
Other
80 stars 80 forks source link

refactor class naming for zeitwerk standard #243

Closed jmartin-tech closed 1 year ago

jmartin-tech commented 1 year ago

Implements comments from #238 about ensuring class name in file matches zeitwerk format for path, this does not yet account for inflectors for RubySMB and NTLM however it gets closer to supporting the zeitwerk patterns.

smcintyre-r7 commented 1 year ago

These changes make sense. Are there any steps for testing anything related to this though?

jmartin-tech commented 1 year ago

Same tests as #238, just need to validate that this still works as expected.

smcintyre-r7 commented 1 year ago

Original fix is still working as expected. I'll get this landed. Thanks @jmartin-r7 !

ruby examples/tree_connect.rb --username юзер --password 'Password1!' 192.168.159.10 IPC$
SMB3 : (0x00000000) STATUS_SUCCESS: The operation completed successfully.
Connected to \\192.168.159.10\IPC$ successfully!