search

rapid7 / ruby_smb

A native Ruby implementation of the SMB Protocol Family
Other
80 stars 80 forks source link

Don't crash when the buffer is empty #244

Closed zeroSteiner closed 1 year ago

zeroSteiner commented 1 year ago

When the response status is 'submitted', the certificate buffer may be empty. In that case, don't load the certificate because it will crash.

There will need to be a Metasploit PR to handle cases where the result is :submitted and the certificate is absent.

bwatters-r7 commented 1 year ago

I'm confused by the failure: uninitialized constant Fixnum If it is from the deprecation, then it should fail on 3.1 and 3.0?

adfoster-r7 commented 1 year ago

Separate PR to fix the Fixnum issue: https://github.com/rapid7/ruby_smb/pull/245