search

rapid7 / warvox

http://www.warvox.org/
203 stars 55 forks source link

Update to Rails 5 #47

Closed ghost closed 8 years ago

ghost commented 8 years ago

Hi,

Sorry about the large pull request but this updates the master branch to rails5, I am not sure if you want to merge this straight into the master branch or create a new rails 5 branch which was done for the rails 4 update?

Let us know tho!

Cheers

hdm commented 8 years ago

@beardyjay Thank you for taking this on! I had a few half-hearted attempts to do this prior, but you seemed to have solved the hairy issues with this PR. Merging straight to master works for me, since Rails 4.0 is now obsolete wrt security patches.

ghost commented 8 years ago

@hdm nice one! I had a bit of a issue with the JobsController but @cheeyeo got that sorted out fairly quickly. Let us know if you see any issues, ran it a few times against a test asterisk install and seemed to work fine.

hdm commented 8 years ago

Going to merge this as-is and if there are any issues, we can address in master, which is still an improvement from the current status. Thanks again!