search

rapideditor / temaki

🐡 An icon expansion pack for Maki
https://rapideditor.github.io/temaki/docs
Other
78 stars 22 forks source link

Add icon for shared pedestrian and cyclist crossing #55

Closed hikemaniac closed 4 years ago

hikemaniac commented 4 years ago

This is a properly rebased version of #54. Sorry for messing that PR up. 😅 This PR adds an icon for a crossing for both cyclists and pedestrians. I used the already existing pedestrian_crosswalk and the pedestrian_and_cyclist icons as the basis for the new icon.

quincylvania commented 4 years ago

@hikemaniac Thanks, looks good! In the future it'd be helpful if you could add a screenshot preview of the icon but it's no big deal.

bhousel commented 4 years ago

Not a huge deal, but I'd like to clean it up later to use a 15px by 15px viewbox.

quincylvania commented 4 years ago

I'd like to clean it up later to use a 15px by 15px viewbox.

Good idea. I took care of this and also shortened the name to make it more manageable.

bhousel commented 4 years ago

Good idea. I took care of this and also shortened the name to make it more manageable.

Thanks! 👍

hikemaniac commented 4 years ago

Thank you a lot! :+1: Interestingly, Inkscape displayed my icon with a 15x15px viewbox. I have no idea what went wrong. :confused:

quincylvania commented 4 years ago

The size was 15x15 but the coordinates were defined in a smaller range and then translated to appear centered in the 15x15 box. It's a bit confusing.

Edit: It actually looks like the coordinates were defined for a 3.9687 by 3.9688 rectangle then scaled up to 15x15. Weird!

hikemaniac commented 4 years ago

@quincylvania Thank you for explaining! Inkscape really does seem to be a very creative piece of software. 😆