search

rapideditor / temaki

🐡 An icon expansion pack for Maki
https://rapideditor.github.io/temaki/docs
Other
77 stars 22 forks source link

add an icon for pedestrian crossing signals (traffic light controlled… #66

Closed dieterdreist closed 3 years ago

dieterdreist commented 3 years ago

… pedestrian crossings)

references: https://github.com/bryceco/GoMap/issues/525

dieterdreist commented 3 years ago

is there an issue with the icon? I thought this would be uncontested.

bhousel commented 3 years ago

Sorry I wasn't paying much attention to this repo lately. It looks like you just copied the railway signals icon - is this a mistake?

Screen Shot 2021-07-06 at 9 26 51 AM
dieterdreist commented 3 years ago

oops, the railway signals is the same? I actually took the highway traffic signals icon and removed the third circle. This is following the same concept as they do it in JOSM.

Sorry, I wasn't aware it is already used for railway signals. If the icon is not needed, maybe we can simply show this icon also for pedestrian crossings that are controlled by traffic signals? These are very common and much more of interest to a "generic" person than railway signals (expert niche). I would guess that there wouldn't be overlap between railway signals (which are on rails) and pedestrian crossings (which are on roads)?

Would you be open to use a different icon for railway signals if I provided one?

The example images in the wiki are these:

bhousel commented 3 years ago

This is a repo where we collect icons, and I can't accept a PR for an icon that we already have..

Downstream projects can use the temaki icons for whatever purpose they want - If someone wants to use our railway signals icon to represent a signalized pedestrian crossing, that's ok with me..

I kind of think it would make more sense for these projects to use one of these existing crossing-like icons that temaki provides:

dieterdreist commented 3 years ago

Am Di., 6. Juli 2021 um 17:39 Uhr schrieb Bryan Housel < @.***>:

This is a repo where we collect icons, and I can't accept a PR for an icon that we already have..

Downstream projects can use the temaki icons for whatever purpose they want - If someone wants to use our railway signals icon to represent a signalized pedestrian crossing, that's ok with me..

I kind of think it would make more sense for these projects to use one of these existing crossing-like icons that temaki provides:

the scope of the icon is to highlight the traffic lights, the icons you show are already used for marked crossings