search

rapidftr / tracker

The Issue Tracker for RapidFTR
2 stars 3 forks source link

Ability to delete Form Sections #136

Closed tomclement closed 10 years ago

tomclement commented 10 years ago

Presently when a RapidFTR admin adds a new form section to the forms on the web, it is not possible to delete that form section afterwards. Given that RapidFTR should be as flexible as possible - especially with regard to the forms, it should be possible to delete newly created form sections.

baziwane commented 10 years ago

GIVEN that I am an ADMIN WHEN I am viewing a form section's details THEN I should see an icon that allows me to delete the form section

GIVEN that I am an ADMIN WHEN I click on the icon to delete the form section THEN I should be prompted to confirm whether I wish to delete the section

GIVEN that I am an ADMIN WHEN I confirm that I wish to delete the form section THEN the section should no longer appear in the list of form sections AND I should be able to view a success message "Form section XYZ deleted successfully".

screen shot 2014-07-29 at 2 53 11 pm

rdsubhas commented 10 years ago

Removing from Kampala Code Jam because this has dependencies on Form Builder for Enquiries #55

rdsubhas commented 10 years ago

@baziwane @tomclement this is implemented (thanks to @raoufaghrout and @robmiles), can you pls have a look...

baziwane commented 10 years ago

Awesome. Thanks @raoufaghrout and @robmiles

@baziwane https://github.com/baziwane @tomclement https://github.com/tomclement this is implemented (thanks to @raoufaghrout https://github.com/raoufaghrout and @robmiles https://github.com/robmiles), can you pls have a look...

— Reply to this email directly or view it on GitHub https://github.com/rapidftr/tracker/issues/136#issuecomment-52079037.

robmiles commented 10 years ago

@baziwane check out the discussion in the pull request https://github.com/rapidftr/RapidFTR/pull/693#issuecomment-52078668 We had some trouble with the placing of the Delete button due to nesting of HTML forms so it's not where it was requested in this issue. I also had a question about whether we should be checking the Editable flag of the FormSection?

tomclement commented 10 years ago

Taking a look at this...

tomclement commented 10 years ago

@raoufaghrout @robmiles The functionality all looks good. Thanks for this! 👍

However in the meantime we'll be holding this card in QA Blocked until this Pull Request is reopened and merged. That should ensure we don't forget to fix those tests

robmiles commented 10 years ago

No worries - we should have that recommitted fairly soon

raouf-aghrout commented 10 years ago

I've just submitted a new pull request that's just running on Travis CI now, fingers crossed!

tomclement commented 10 years ago

@RaoufAghrout @robmiles Build passed! Merging this right away..

tomclement commented 10 years ago

Functional tests fixed with https://github.com/rapidftr/RapidFTR/pull/700. This is now ready for accepance