rapidftr / tracker

The Issue Tracker for RapidFTR
2 stars 3 forks source link

Mark/unmark enquiry field as searchable and view resulting matches #187

Closed baziwane closed 10 years ago

baziwane commented 10 years ago

Create a page that allows an admin to define which fields of an enquiry form to use in searching for matching child records.

baziwane commented 10 years ago

GIVEN that I am an ADMIN WHEN viewing the list of form fields in a form section THEN I should be able to mark and unmark a field as searchable

GIVEN that I am an ADMIN WHEN I mark an enquiry field as searchable THEN I should view all resulting child records matching this field

GIVEN that I am an ADMIN WHEN I unmark a field as no longer searchable THEN I shouldn't view child records matched to this field

baziwane commented 10 years ago

Hi @scampo just need some context on a scenario related to this card. If a user creates an enquiry but doesn't complete any of the searchable/matchable fields (e.g. doesn't complete the child sought form section), do we proceed and save the enquiry knowing it's not "useful"? My thought was inclined to saving the enquiry but display a warning at the top that user hasn't filled any searchable fields?? I'm assuming this scenario would only occur in cases when user's intent was to return and complete the enquiry.

baziwane commented 10 years ago

@scampo as agreed the scenario is very highly unlikely so we proceed with assumption that this won't happen and thus no need to display warning message as had earlier suggested.

tomclement commented 10 years ago

Just noticed that when a field in an enquiry that is matchable is populated with only whitespace, then all existing children are presented as potential matches. I suppose this is a fairly unlikely scenario, but should it happen, it would be very confusing to the user.

Tracking this in rapidftr/tracker/issues/194

scampo commented 10 years ago

This is not necessarily unlikely, as incompleteness of fields remains an issue.

This seems like a bug rather than an acceptable component of the functionality. This should be resolved.


Stuart Campo Innovation Unit, UNICEF scampo@unicef.org

+254.718.764526 (Kenya)* +211.921.379121 (South Sudan) +256.779.234347 (Uganda) +1.802.249.8233 (U.S.) Skype: stuart.campo

*currently in Kenya

www.unicefstories.org

On Thu, Sep 4, 2014 at 12:46 PM, Tom Clement Oketch < notifications@github.com> wrote:

Just noticed that when a field in an enquiry that is matchable is populated with only whitespace, then all existing children are presented as potential matches. I suppose this is a fairly unlikely scenario, but should it happen, it would be very confusing to the user.

Tracking this in rapidftr/tracker#194 https://github.com/rapidftr/tracker/issues/194

— Reply to this email directly or view it on GitHub https://github.com/rapidftr/tracker/issues/187#issuecomment-54442557.

tomclement commented 10 years ago

I agree @scampo.. this should be resolved. However, what I mean about it being unlikely is that we are already safeguarding against fields with absolutely no values (as evidenced in this pull request). However where the problem arises is if a user unknowingly enters only whitespace into a field - this is where this particular bug would manifest.

scampo commented 10 years ago

OK -- that makes sense. Regardless, let's please flag it and address it.


Stuart Campo Innovation Unit, UNICEF scampo@unicef.org

+254.718.764526 (Kenya)* +211.921.379121 (South Sudan) +256.779.234347 (Uganda) +1.802.249.8233 (U.S.) Skype: stuart.campo

*currently in Kenya

www.unicefstories.org

On Thu, Sep 4, 2014 at 2:09 PM, Tom Clement Oketch <notifications@github.com

wrote:

I agree @scampo https://github.com/scampo.. this should be resolved. However, what I mean about it being unlikely is that we are already safeguarding against fields with absolutely no values (as evidenced in this pull request https://github.com/rapidftr/RapidFTR/pull/725). However where the problem arises is if a user unknowingly enters only whitespace into a field - this is where this particular bug would manifest.

— Reply to this email directly or view it on GitHub https://github.com/rapidftr/tracker/issues/187#issuecomment-54454194.

tomclement commented 10 years ago

Sure @scampo. We will be holding this story in QA blocked until that bug is resolved.