Upgrade to RSpec 3.0 - Githubissues

rapidftr / tracker

The Issue Tracker for RapidFTR

2 stars 3 forks source link

Upgrade to RSpec 3.0 #78

Open rdsubhas opened 10 years ago

rdsubhas commented 10 years ago

RSpec 3.0 is released, and there is the excellent transpec gem which bulk converts all old x.should == y syntax into the new expect(x).to be(y) syntax.

As part of this story, upgrade to either RSpec 3.0 or RSpec 2.99. 2.99 is the same as 3.0 except it treats all deprecations as warnings but still continues, where as 3.0 simply errors out.

sferik commented 10 years ago

There are a couple cleanup tasks related to this issue:

[ ] Fix deprecation warning from rspec in factories.rb
[ ] Using private method proxy_for in RSpec::Mocks

@rdsubhas Does it make sense to re-open this issue until these are also fixed?

The second issue wasn’t introduced by https://github.com/rapidftr/RapidFTR/pull/650, we just realized it was an issue in the process of upgrading to RSpec 3.

rdsubhas commented 10 years ago

Oops @sferik @RapidRailsGirls thanks for pointing it out, I closed the two other issues #117 #119 thinking they were done as part of this :) Yep re-opening this

rdsubhas commented 10 years ago

@sferik @RapidRailsGirls do you think we can close this issue now?

sferik commented 10 years ago

@rdsubhas The cleanup tasks still need to be completed.