search

rapidfuzz / RapidFuzz

Rapid fuzzy string matching in Python using various string metrics
https://rapidfuzz.github.io/RapidFuzz/
MIT License
2.61k stars 116 forks source link

Non-standard function signature for `get_requires_for_build_wheel()` #303

Closed troycurtisjr closed 1 year ago

troycurtisjr commented 1 year ago

The function signature for get_requires_for_build_wheel() in _custom_build/backend.py has "self" as the first parameter, however PEP 517 lists it only with config_settings. The setuptools.build_meta.get_requires_for_build_wheel original implementation that this function "overrides" is actually a bound method, and thus doesn't take the self parameter.

It seems like that function is being used somewhere, since it seems to be getting updates, but I haven't tracked it down exactly where that is.

maxbachmann commented 1 year ago

It appears you are correct. I opened a PR in setuptools to fix the corresponding documentation and will fix this in my build backend.

maxbachmann commented 1 year ago

I fixed this in https://github.com/maxbachmann/RapidFuzz/commit/8eadc371b09f25afd28737f7ad9b17a343da40e2. @troycurtisjr do you need a new release with this fix?

troycurtisjr commented 1 year ago

A new release would be great, but I can just apply a patch for now until a new release naturally happens.

maxbachmann commented 1 year ago

I created a new release with the fix. It will be available once the CI is finished (usually takes 2-3 hours)